Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

Addresses review feedback from PR #4 review thread by fixing test infrastructure issues.

Test lifecycle fix:

  • Renamed test_asyncTearDown()asyncTearDown() in tests/test_func.py
  • Method was running as a test instead of teardown, leaving Redis connections unclosed after each test

Test assertion cleanup:

  • Removed redundant assertTrue(fq._r is None) in tests/test_edge_cases.py
  • assertIsNone(fq._r) already present on previous line with better error messages

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ochui <21917688+ochui@users.noreply.github.com>
Copilot AI changed the title [WIP] Expand test coverage for FQ queueing system Fix test teardown method and remove redundant assertion Jan 26, 2026
Copilot AI requested a review from ochui January 26, 2026 08:31
@ochui ochui marked this pull request as ready for review January 26, 2026 08:39
Copilot AI review requested due to automatic review settings January 26, 2026 08:39
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes async test teardown wiring so cleanup runs correctly, and removes a redundant assertion in edge case tests.

Changes:

  • Renamed test_asyncTearDown to asyncTearDown so unittest.IsolatedAsyncioTestCase runs teardown properly after each async test.
  • Removed a duplicate assertTrue(fq._r is None) in favor of the existing assertIsNone(fq._r).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/test_func.py Renames the teardown method to the correct asyncTearDown hook to ensure Redis cleanup executes after each test.
tests/test_edge_cases.py Removes a redundant assertion, keeping the clearer assertIsNone check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ochui ochui merged commit e19112a into test/coverage Jan 26, 2026
7 checks passed
@ochui ochui deleted the copilot/sub-pr-4 branch January 26, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants