refactor: use slices.Contains to simplify code

[slightsharp]

Overview

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

[gemini-code-assist]

Summary of Changes

Hello @slightsharp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors existing code by integrating new functions from the Go 1.21 slices package. The changes aim to improve code readability and conciseness by replacing manual loop-based checks with more idiomatic and efficient slices.Contains and slices.ContainsFunc calls, streamlining array and slice operations across the codebase.

Highlights

• Code Simplification: Replaced manual iteration and comparison with slices.Contains in pkg/rpc/server/da_visualization.go for checking blob ID existence, making the code more concise.
• Functional Programming Style: Utilized slices.ContainsFunc in tools/local-da/rpc.go to simplify checking for namespace existence, leveraging a predicate function for cleaner logic.
• Go 1.21 slices Package Adoption: Adopted new functions from the Go 1.21 standard library's slices package to improve code readability and maintainability by using idiomatic Go constructs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the code to use slices.Contains and slices.ContainsFunc from Go 1.21, which simplifies the logic by replacing manual loops. The changes are a good step towards more concise code. I've left one comment on tools/local-da/rpc.go to add a nil check, which will prevent a potential panic and improve the robustness of the code.

[julienrbrt]

Thanks!

[codecov]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.98%. Comparing base (9a91394) to head (f467e72).

Files with missing lines	Patch %	Lines
pkg/rpc/server/da_visualization.go	0.00%	5 Missing ⚠️
tools/local-da/rpc.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3010      +/-   ##
==========================================
- Coverage   57.99%   57.98%   -0.02%     
==========================================
  Files         110      110              
  Lines       10526    10522       -4     
==========================================
- Hits         6105     6101       -4     
  Misses       3770     3770              
  Partials      651      651              

Flag	Coverage Δ
combined	57.98% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.