Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jan 29, 2026

Ticket ENG-1237

Description Of Changes

Filter GPP-related notices from the list of available privacy notices when adding notices to a TCF experience in the Admin UI. This prevents the issue where adding a GPP notice to a TCF experience results in an empty meta field in the /privacy-experience endpoint response.

Code Changes

  • Added `filterGppNotices` function to filter out notices with `gpp_us_national` or `gpp_us_state` framework
  • Updated `allPrivacyNoticesWithTcfPlaceholder` to apply GPP filtering before building the notice list for TCF experiences
  • Imported `PrivacyNoticeFramework` enum to identify GPP notices

Steps to Confirm

  1. Create or edit a TCF overlay experience in the Admin UI
  2. Click "Add privacy notice" in the Privacy notices section
  3. Verify that GPP notices (with `gpp_us_national` or `gpp_us_state` framework) do not appear in the list of available notices
  4. Verify that non-GPP notices are still available and can be added successfully
  5. Verify that GPP notices can still be added to non-TCF experiences

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • `CHANGELOG.md` updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on `main`
    • Ensure that your `downgrade()` migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 29, 2026 11:44pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Jan 29, 2026 11:44pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants