Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Jan 29, 2026

Ticket []

Description Of Changes

Refactors the activity tab to use the new monitor key filter instead of the generic search input when scoped to a monitor.
As a bonus added some style fixes to the monitor list filters
Depends on: https://github.com/ethyca/fidesplus/pull/3022

Code Changes

Steps to Confirm

  1. Visit the Action Center screen and click on a monitor
  2. Click on the Activity tab
  3. Confirm that only activity from the current monitor are displayed

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@speaker-ender speaker-ender requested a review from a team as a code owner January 29, 2026 21:53
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team January 29, 2026 21:53
@vercel
Copy link
Contributor

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 30, 2026 4:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Jan 30, 2026 4:43pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR refactors the activity tab to use a dedicated monitor_config_key filter parameter instead of repurposing the generic search input when viewing tasks scoped to a specific monitor.

Key improvements:

  • Separates monitor-specific filtering from general search functionality by introducing a dedicated monitor_config_key query parameter in the API call
  • Hides the search input when viewing a monitor-specific activity page, improving UX clarity
  • Renames variables from monitorId to monitorKey for better semantic accuracy (the URL parameter contains the monitor's config key, not its ID)
  • Includes style fixes to the monitor list filters (reduced gaps and removed default margins)

The changes are clean, well-structured, and properly thread the new filter parameter through the component hierarchy. The PR depends on backend API changes in fidesplus#3022 to support the new monitor_config_key parameter.

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • The refactor is straightforward, logically sound, and follows existing patterns. All changes are cohesive and properly implement the separation of monitor-specific filtering from general search. No security concerns, logical errors, or breaking changes identified.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/action-center.slice.ts Added monitor_config_key parameter to the query API for filtering tasks by monitor
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useInProgressMonitorTasksList.tsx Updated hook to accept monitorKey filter and pass it as monitor_config_key to API instead of using search
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InProgressMonitorTasksList.tsx Updated to hide search input when monitorKey filter is present, properly separating monitor-specific from general search

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the refactor/activity-tab-monitor-filter branch from eae55e3 to 06bc263 Compare January 30, 2026 16:39
@speaker-ender speaker-ender marked this pull request as ready for review January 30, 2026 16:39
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants