-
Notifications
You must be signed in to change notification settings - Fork 86
refactor: activity tab monitor filter #7273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR refactors the activity tab to use a dedicated Key improvements:
The changes are clean, well-structured, and properly thread the new filter parameter through the component hierarchy. The PR depends on backend API changes in fidesplus#3022 to support the new Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
eae55e3 to
06bc263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Ticket []
Description Of Changes
Refactors the activity tab to use the new monitor key filter instead of the generic search input when scoped to a monitor.
As a bonus added some style fixes to the monitor list filters
Depends on: https://github.com/ethyca/fidesplus/pull/3022
Code Changes
Steps to Confirm
Action Centerscreen and click on a monitorActivitytabPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works