-
Notifications
You must be signed in to change notification settings - Fork 86
Add Transcend cookie migration support to fides.js #7272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
554403e to
46153a9
Compare
Greptile OverviewGreptile SummaryThis PR adds Transcend cookie migration support to fides.js, enabling customers migrating from Transcend to Fides to preserve users' existing consent preferences. The implementation follows the established provider pattern used by the existing OneTrust integration. Key changes:
Issues found:
The implementation is well-structured, follows existing patterns, has excellent test coverage, and handles edge cases appropriately. Confidence Score: 4.5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
46153a9 to
c960521
Compare
Ticket ENG-2063
Description Of Changes
Add support for migrating consent preferences from Transcend's
tcmcookie to Fides consent format, following the same pattern as the existing OneTrust integration. This enables customers migrating from Transcend to Fides to preserve their users' existing consent preferences without requiring users to re-consent.The implementation follows the established provider pattern and keeps bundle size minimal (49.83 KB gzipped, under the 53 KB limit).
Code Changes
TranscendProviderclass implementingConsentMigrationProviderinterfaceTRANSCENDenum value toConsentMigrationProviderNameTranscendToFidesConsentMappingtype definitiontranscendFidesMappingconfiguration option across all config filesSteps to Confirm
<head>of thefides-js-demo.htmlfile ABOVE the first<script>tagNow reload the page and ensure that the fides cookie automatically gets set and that the consent values reflect those of the tcm cookie and the mapping was successful.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works