Enforce CREATE_APPLICATIONS, CREATE_CHANNELS, and CREATE_DMS rights #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds rights enforcement for three declared but previously unenforced instance-wide rights:
POST /applicationsPOST /guilds/:guild_id/channels(in addition to existing MANAGE_CHANNELS permission)POST /users/@me/channelsThese rights were declared in
src/util/util/Rights.tsbut never validated in their respective route handlers, creating security gaps where users could perform actions without the required instance-wide rights.Review & Testing Checklist for Human
src/util/util/Rights.tsat bit positions 10, 11, and 12src/api/util/handlers/route.tsproperly validates therightparameterRecommended test plan: Create a test user with limited rights (excluding these three), then attempt to create an application, guild channel, and DM channel. Verify each request fails with a rights error.
Notes