Feature/config-simplification #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only Remove redundant database-specific configuration fields and consolidate on DATABASE_URL as the single required configuration method (12-factor app pattern). Database type is now automatically detected from URL scheme. Changes: - Refactor GormConfig to use unified fields (Host, Port, User, Password, Database, SSLMode) instead of per-database duplicates - Update DatabaseConfig to require URL, remove legacy Postgres/MySQL/etc blocks - Update all config parsing to use db.ParseDatabaseURL() - Update config-example.yml with simplified DATABASE_URL documentation - Update tests to use TMI_DATABASE_URL instead of legacy env vars Supported URL formats: - postgres://user:pass@host:5432/db?sslmode=require - mysql://user:pass@host:3306/db - sqlserver://user:pass@host:1433?database=db - sqlite:///path/to/file.db - oracle://user:pass@host:1521/service_name Oracle wallet location remains a separate field (TMI_ORACLE_WALLET_LOCATION) as it cannot be encoded in the URL. Closes #93 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… providers Phase 3-5 of configuration simplification (Issue #93): System Settings (Phase 3): - Add SystemSetting model for database-stored configuration - Add SettingsService with TTL caching for settings retrieval - Settings support string, int, bool, and json value types Client Config Endpoint (Phase 4): - Add GET /config endpoint for tmi-ux to retrieve runtime configuration - Returns features, operator info, limits, and UI defaults - Add GET /admin/settings and PUT /admin/settings/{key} for admin management Secret Providers (Phase 5): - Add SecretProvider interface for pluggable secret management - Implement EnvSecretProvider (default, uses environment variables) - Implement AWSSecretsProvider (AWS Secrets Manager integration) - Implement OCISecretsProvider (OCI Vault Secrets integration) - Vault, Azure, GCP providers are config-only (implementation deferred) Additional changes: - Update OpenAPI schema with new endpoints and schemas - Update Heroku setup script to use DATABASE_URL pattern - Update go.mod with AWS SDK and OCI SDK dependencies Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Regenerated api/api.go after OpenAPI schema updates for configuration simplification (Issue #93). Minor changes to discriminator defaults. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The ConnectionPoolConfig struct expects integers (seconds) for conn_max_lifetime and conn_max_idle_time fields, not duration strings. Updated config-example.yml to use integer values with explanatory comments. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing logging env var aliases for TMI_ prefixed variables (TMI_LOG_API_REQUESTS, TMI_LOG_API_RESPONSES, TMI_LOG_WEBSOCKET_MESSAGES, TMI_LOG_REDACT_AUTH_TOKENS, TMI_LOG_SUPPRESS_UNAUTH_LOGS) - Fix typo in Heroku script: TMI_LOG_WEBSOCKET_MSG -> TMI_LOG_WEBSOCKET_MESSAGES - Add TMI_BUILD_MODE=production to Heroku defaults Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…fix directly - Update all struct env tags to use TMI_ prefixed environment variables - Remove envAliases map and deprecation warning system - Remove getEnvWithDeprecationCheck() and logDeprecatedEnvVars() functions - Simplify overrideStructWithEnv() to use os.Getenv() directly - Update config tests to use new TMI_ prefixed env var names Environment variables now require TMI_ prefix (no backward compatibility): - TMI_SERVER_*, TMI_DATABASE_URL, TMI_REDIS_* - TMI_JWT_*, TMI_OAUTH_*, TMI_SAML_* - TMI_LOG_*, TMI_WEBSOCKET_*, TMI_OPERATOR_* Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables now require TMI_ prefix (no backward compatibility):
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com