Skip to content

Conversation

@moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Jan 21, 2026

Proposed commit message

cybereason: add system tests and increase base64 icon field limits to 4096

Add system tests for all data streams.

Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.

Test logs were generated from existing pipeline test logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Jan 21, 2026
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner January 21, 2026 10:50
@moxarth-rathod moxarth-rathod added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:cybereason Cybereason Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jan 21, 2026
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 21, 2026

🚀 Benchmarks report

Package cybereason 👍(2) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malop_process 805.15 451.06 -354.09 (-43.98%) 💔
malware 10526.32 8000 -2526.32 (-24%) 💔

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jan 21, 2026
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message. At the moment it does not make any comment on the test addition. The work here is more complex than the proposed commit message would suggest. There are new test samples in the docker config, so the origin of these should be described in the commit message.

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

@moxarth-rathod moxarth-rathod requested a review from efd6 January 22, 2026 07:18
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:

cybereason: add system tests and increase base64 icon field limits to 4096

Add system tests for all data streams.

Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.

Test logs were generated from existing pipeline test logs.

U69uQBo/agO7
-----END CERTIFICATE-----
assert:
hit_count: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I confirm that where we have assert.hit_count: 1 you have made this choice because the agent is not paginating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only the malware data stream has pagination.

@moxarth-rathod moxarth-rathod requested a review from efd6 January 23, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cybereason Cybereason Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants