-
Notifications
You must be signed in to change notification settings - Fork 530
[Cybereason] Add system test coverage #17017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Cybereason] Add system test coverage #17017
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
malop_process |
805.15 | 451.06 | -354.09 (-43.98%) | 💔 |
malware |
10526.32 | 8000 | -2526.32 (-24%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit message. At the moment it does not make any comment on the test addition. The work here is more complex than the proposed commit message would suggest. There are new test samples in the docker config, so the origin of these should be described in the commit message.
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
💚 Build Succeeded
History
|
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest:
cybereason: add system tests and increase base64 icon field limits to 4096
Add system tests for all data streams.
Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.
Test logs were generated from existing pipeline test logs.
| U69uQBo/agO7 | ||
| -----END CERTIFICATE----- | ||
| assert: | ||
| hit_count: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I confirm that where we have assert.hit_count: 1 you have made this choice because the agent is not paginating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the malware data stream has pagination.
Proposed commit message
Checklist
changelog.ymlfile.Related issues