Containerised distribution of Guardian main branch #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
force-pushed
the
containerised
branch
2 times, most recently
from
b0942e9 to
887a0ca
Compare
tonytw1
force-pushed
the
containerised
branch
2 times, most recently
from
5b3abf6 to
5df2f75
Compare
tonytw1
force-pushed
the
containerised
branch
6 times, most recently
from
db06496 to
8f64bac
Compare
tonytw1
force-pushed
the
containerised
branch
7 times, most recently
from
e8ad009 to
3ce864b
Compare
tonytw1
force-pushed
the
containerised
branch
3 times, most recently
from
4810e23 to
779c5c4
Compare
tonytw1
force-pushed
the
containerised
branch
from
779c5c4 to
a3135c0
Compare
tonytw1
force-pushed
the
containerised
branch
from
a3135c0 to
5eb0f1f
Compare
tonytw1
force-pushed
the
containerised
branch
from
5eb0f1f to
d8ede2b
Compare
tonytw1
force-pushed
the
containerised
branch
from
d8ede2b to
28d90ef
Compare
tonytw1
force-pushed
the
containerised
branch
from
28d90ef to
0ca45e2
Compare
tonytw1
force-pushed
the
containerised
branch
from
0ca45e2 to
e4dbaad
Compare
tonytw1
force-pushed
the
containerised
branch
2 times, most recently
from
766edbf to
8dadbde
Compare
…emoving non time zoned date formatter which was shadowing the long standing time zoned date formatter.
Add a British summer time YYYY-MM-dd example to show that this formatter is locale dependant.
DateTimeFormat.forPattern("yyyy-MM-dd") matches the same pattern as ISODateTimeFormat.date.withZoneUTC but removes the withZoneUTC behaviour.
I do not know if that was intentional but FileMetadataReaderTest was a long standing test so this could be considered a regression.
Additionally, that entire block of date formatters probably have an indeterminate outcome.
…a API. This call was probably the only service to service call circa 2021. GridClient appears to be how more recent service to service calls are done. Moving this call to GridClient helps to enclosure all the service to service url concerns in one place. Get SourceImage requests additional fields via media-api query parameters. Extract the media api uri to image id extraction to a function for testing.
…ork out AWS roles in containers for now. Use only ENV AWS creds; should stop AWS auth endpoint timeouts on first hit.
com.typesafe.config.ConfigException$NotResolved: need to Config#resolve() each config before using it, see the API docs for Config#resolve()
sbt universal, then straight to sbt docker may be the correct path now. Play framework assembly docs do not help with Caused by: java.lang.ClassNotFoundException: play.core.server.ProdServerStart Attempt to build thrall as a fat jar using assembly. Reminder of what Thrall does.
cmyk.icc is required for ingesting CMKY colour space JPEGs.
…image builds. Remove redundant debianPackageDependencies options.
…all api host name to be internalised. Interface only talks about base URIs.
Split url Services into a trait and a Guaridan specific implementation; exposes a few 4th wall breaking direct init's in services.
…s supplied by common config; no need to trouble yourselves with the details of how those urls are defined.
…documented access to the private url building concerns.
…n the single hostname. Will work because HTTPS auth is not active. CORS for single host urls. Projection end points are on the image-loader service but have seperate config to permit reingession workloads to be on different instances.
We have used it to shape the Service interface. It can be dropped now.
Config single.host.url is exclusively for our single host setup.
No longer gets bypassed thanks to preceding CORS check; CORS filter does not appear to tag the request if it passes for same origin.
"checks connectivity to all other internal services..." which sounds like something we can let the container orchestrator handle. InnerServiceStatusCheckController was the only user of Services.allInternalUris
Removes a bucket dependency.
…rement. Remove usages UsageGroups from Guardian Content methods. Remove usages CAPI client and it's config. Delete usages streaming mode Crier steam listening and CAPI specific reindexForContent end point. Container consumers are never going to be Guardian internal. External users would integrate their streams by having a microapp or Lambda ping the instance specific usages API. We can drop this Guardian specific code and config.
Faster and lighter. Better colour profile support. Generate an imgproxy style preview URL. Move service name from imgops to imgproxy. Disable EXIF autorotation and explicitly correct rotation. imgproxy does not accept negative rotations. Be explicit about stripping colour profile to force sRGB.
… size than default ergonomics. 60% was running close to the OOM kill limit on Java 11 and Java 22 has nudged it into OOM kill.
x86 images only. Multi arch is too slow (14 mins) as buildx repeats the apt-get steps. Cloudbuild uses node 24 for Kahuna build. Explicit jdk 11 build in Cloudbuild build.
tonytw1
force-pushed
the
containerised
branch
from
8dadbde to
b1d31d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Produces container images for a generalised Grid install based on the Guardian's
mainbranch.Reasonably opinionated towards "we use AWS services but we don't necessarily run the application on AWS".
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?