K3D based cluster with ServiceLB #7

hellt · 2026-01-13T11:52:47Z

k3d with k3s ServiceLB

Copilot

Pull request overview

This PR migrates the EDA Codespaces environment from using kind to k3d with k3s ServiceLB. The change enables built-in load balancer support, removing the need for external load balancing solutions.

Changes:

Switched from kind to k3d cluster with k3s v1.34.1-k3s1, enabling ServiceLB
Simplified token extraction logic in postCreate script
Added Keycloak configuration for Codespaces frontend URL handling
Relocated sysctl configuration to initCommand phase for earlier execution

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
README.md	Commented out 8vCPU Codespaces option (likely for cost/resource reasons)
.devcontainer/postCreate.sh	Simplified token extraction and removed ensure-docker-is-ready call
.devcontainer/postAttach.sh	Updated ASCII art banner with new design
.devcontainer/overrides.mk	Added Keycloak configuration target and engine config patching
.devcontainer/onCreate.sh	Changed from kind to k3d cluster with ServiceLB enabled, removed sysctl calls
.devcontainer/initCommand.sh	New file containing sysctl configuration moved from onCreate
.devcontainer/engine-config-patch.yaml	New configuration file for custom CPU settings
.devcontainer/devcontainer.json	Updated base image tag and added initializeCommand
.devcontainer/Dockerfile	Changed repo branch from v0.0.1 to main, removed font installation, added networking tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T18:38:44Z

.devcontainer/postCreate.sh

+# get token
+encoded=$(grep 'GH_PKG_TOKEN ?=' "Makefile" | sed 's/.*?= *//')
+prefix=$(printf '%s' 'Z2hwCg==' | base64 -d)
+suffix=$(printf '%s' "$encoded" | base64 -d | cut -c 4- | tr -d '\n')
+TOKEN="${prefix}${suffix}"


The token extraction logic appears to be reconstructing a GitHub token from base64-encoded parts. This approach obscures the token but doesn't provide real security. Consider using GitHub's built-in secrets or environment variables (GITHUB_TOKEN) available in Codespaces instead of hardcoding token components in the codebase.

Suggested change

# get token

encoded=$(grep 'GH_PKG_TOKEN ?=' "Makefile" | sed 's/.*?= *//')

prefix=$(printf '%s' 'Z2hwCg==' | base64 -d)

suffix=$(printf '%s' "$encoded" | base64 -d | cut -c 4- | tr -d '\n')

TOKEN="${prefix}${suffix}"

# get token from environment (prefer GH_PKG_TOKEN, fallback to GITHUB_TOKEN)

if [ -n "$GH_PKG_TOKEN" ]; then

TOKEN="$GH_PKG_TOKEN"

elif [ -n "$GITHUB_TOKEN" ]; then

TOKEN="$GITHUB_TOKEN"

else

echo "Error: GitHub token not set. Please set GH_PKG_TOKEN or GITHUB_TOKEN in the environment." >&2

exit 1

fi

Copilot · 2026-01-13T18:38:45Z

.devcontainer/postCreate.sh

+# preload images into the cluster from the EDA core list
+# to reduce the number of jobs: PARALLEL_JOBS=$(($(nproc) - 1))
+PARALLEL_JOBS=$(nproc)
+docker exec k3d-eda-demo-server-0 sh -c "cat /opt/images.txt | xargs -P $PARALLEL_JOBS -I {} crictl pull --creds nokia-eda-bot:$TOKEN {}"


This command has no error handling. If the docker exec fails (e.g., if the k3d cluster isn't ready yet or the container name is incorrect), the script will continue silently. Consider adding error checking with set -e at the start of the script or explicitly checking the exit status of this command.

Suggested change

docker exec k3d-eda-demo-server-0 sh -c "cat /opt/images.txt | xargs -P $PARALLEL_JOBS -I {} crictl pull --creds nokia-eda-bot:$TOKEN {}"

if ! docker exec k3d-eda-demo-server-0 sh -c "cat /opt/images.txt | xargs -P $PARALLEL_JOBS -I {} crictl pull --creds nokia-eda-bot:$TOKEN {}"; then

echo "Error: failed to preload images into the k3d cluster" >&2

exit 1

fi

Copilot · 2026-01-13T18:38:45Z

.devcontainer/overrides.mk

+.PHONY: start-ui-port-forward
+start-ui-port-forward:
+	@{	\
+		echo "--> Triggering browser window open 0.0.0.0:9443"	;\


The start-ui-port-forward target only logs a message but doesn't actually trigger any browser action or perform port forwarding. Either implement the actual functionality or remove this target if it's not yet ready.

Suggested change

echo "--> Triggering browser window open 0.0.0.0:9443" ;\

URL="https://0.0.0.0:9443" ;\

echo "--> INFO: Opening browser window at $$URL" ;\

if command -v xdg-open >/dev/null 2>&1; then \

xdg-open "$$URL" >/dev/null 2>&1 || echo "--> WARNING: Failed to open browser with xdg-open" ;\

elif command -v open >/dev/null 2>&1; then \

open "$$URL" >/dev/null 2>&1 || echo "--> WARNING: Failed to open browser with open" ;\

else \

echo "--> INFO: Could not find a supported browser opener (xdg-open/open). Please open $$URL manually." ;\

fi ;\

Copilot · 2026-01-13T18:38:45Z

.devcontainer/Dockerfile

 USER vscode

-RUN git clone --depth 1 --branch v0.0.1 "https://github.com/$EDA_PLAYGROUND_REPO" $EDA_PLAYGROUND_DIR && cd $EDA_PLAYGROUND_DIR && \
+RUN git clone --depth 1 --branch main "https://github.com/$EDA_PLAYGROUND_REPO" $EDA_PLAYGROUND_DIR && cd $EDA_PLAYGROUND_DIR && \


Switching from a tagged release (v0.0.1) to the main branch reduces reproducibility and could introduce breaking changes. Consider using a specific tag or commit SHA for production environments to ensure consistent builds.

Copilot · 2026-01-13T18:38:45Z

.devcontainer/Dockerfile

    procps \
    vim \
-    fontconfig \
    xz-utils \


The addition of net-tools and iputils-ping packages is undocumented. Consider adding a comment explaining why these networking diagnostic tools are needed (e.g., for debugging k3d networking issues).

Suggested change

xz-utils \

xz-utils \

# Networking diagnostic tools (e.g., for debugging k3d networking issues inside the devcontainer)

hellt and others added 30 commits January 12, 2026 18:04

remove k3s and use trixie

b09bb2a

try kind

4bf0307

clone main

61be48e

maybe lets go back to bookworm

b019444

hidden images

6f6ea42

use LB with kind

4eab4ee

use token from playground

2b54b04

strip newline

55a3726

added username

bc2318d

time to eda

3ece3c8

run eda

40db7bf

patch kc

39f6ede

added the right target

c3c13bb

try an override of deps in make for kc patching

3b6b28c

give k apply some time

78a83fd

wait longer

db30032

k3d with lb

cccd979

set image

e724e3e

install k3d

4d18878

add username

b9edba4

Use EDA port env var

8bfb58f

overrides everywhere

981cb5c

added no-lb

818aa38

Better log message for reconcile timeout

89e051b

no v6 in codespaces for k3d?

e021f8f

internal k3d lb

9109cd8

nolb in make

956c9b8

shunt port forwarding

549f962

patch location

6041ada

breath room for pulling

3702fc2

kaelemc and others added 13 commits January 13, 2026 15:16

fresh coat of paint on postAttach

ffa99b4

one more time bby

9569f6e

set https port

45bbac7

patch eda svc

62a90c1

trigger auto window opener

fe65bf8

forward 9443 -> 443

c67d6bb

init command and net tools

7f12c10

jobs as much as cores

5f248b8

EDA UI text

2c50c85

trigger window open?

e20e60d

remove 8vcpu btn

a54575b

added permissions

7fe14df

buttons in a row

6b1c751

hellt marked this pull request as ready for review January 13, 2026 18:32

Copilot AI review requested due to automatic review settings January 13, 2026 18:32

Copilot started reviewing on behalf of hellt January 13, 2026 18:32 View session

hellt changed the title ~~Try k3d~~ K3D based cluster with ServiceLB Jan 13, 2026

This was referenced Jan 13, 2026

Don't disable ServiceLB in k3s #5

Closed

Try Kind #6

Closed

hellt merged commit 1d548a3 into main Jan 13, 2026
5 checks passed

hellt deleted the try-k3d-lb branch January 13, 2026 18:36

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

K3D based cluster with ServiceLB #7

K3D based cluster with ServiceLB #7

Uh oh!

hellt commented Jan 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-# get token
-encoded=$(grep 'GH_PKG_TOKEN ?=' "Makefile" | sed 's/.*?= *//')
-prefix=$(printf '%s' 'Z2hwCg==' | base64 -d)
-suffix=$(printf '%s' "$encoded" | base64 -d | cut -c 4- | tr -d '\n')
-TOKEN="${prefix}${suffix}"
+# get token from environment (prefer GH_PKG_TOKEN, fallback to GITHUB_TOKEN)
+if [ -n "$GH_PKG_TOKEN" ]; then
+    TOKEN="$GH_PKG_TOKEN"
+elif [ -n "$GITHUB_TOKEN" ]; then
+    TOKEN="$GITHUB_TOKEN"
+else
+    echo "Error: GitHub token not set. Please set GH_PKG_TOKEN or GITHUB_TOKEN in the environment." >&2
+    exit 1
+fi

-docker exec k3d-eda-demo-server-0 sh -c "cat /opt/images.txt | xargs -P $PARALLEL_JOBS -I {} crictl pull --creds nokia-eda-bot:$TOKEN {}"
+if ! docker exec k3d-eda-demo-server-0 sh -c "cat /opt/images.txt | xargs -P $PARALLEL_JOBS -I {} crictl pull --creds nokia-eda-bot:$TOKEN {}"; then
+    echo "Error: failed to preload images into the k3d cluster" >&2
+    exit 1
+fi

-		echo "--> Triggering browser window open 0.0.0.0:9443"	;\
+		URL="https://0.0.0.0:9443"																							;\
+		echo "--> INFO: Opening browser window at $$URL"																	;\
+		if command -v xdg-open >/dev/null 2>&1; then																		\
+			xdg-open "$$URL" >/dev/null 2>&1 || echo "--> WARNING: Failed to open browser with xdg-open"					;\
+		elif command -v open >/dev/null 2>&1; then																			\
+			open "$$URL" >/dev/null 2>&1 || echo "--> WARNING: Failed to open browser with open"							;\
+		else																												\
+			echo "--> INFO: Could not find a supported browser opener (xdg-open/open). Please open $$URL manually."		;\
+		fi																													;\

	xz-utils \
	xz-utils \
	# Networking diagnostic tools (e.g., for debugging k3d networking issues inside the devcontainer)

K3D based cluster with ServiceLB #7

K3D based cluster with ServiceLB #7

Uh oh!

Conversation

hellt commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hellt commented Jan 13, 2026 •

edited

Loading