Skip to content

Conversation

@marcosbento
Copy link
Collaborator

@marcosbento marcosbento commented Jan 28, 2026

Description

Adjust clangformat's PackConstructorInitializers to Never

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-274

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 20.31603% with 706 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.21%. Comparing base (43e9f98) to head (be3b3fe).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/InfoProvider.cpp 0.00% 20 Missing ⚠️
Viewer/ecflowUI/src/NodeExpression.hpp 0.00% 16 Missing ⚠️
Viewer/ecflowUI/src/VFilter.cpp 0.00% 13 Missing ⚠️
Viewer/ecflowUI/src/RepeatEditor.cpp 0.00% 12 Missing ⚠️
Viewer/ecflowUI/src/TriggerCollector.hpp 0.00% 11 Missing ⚠️
Viewer/ecflowUI/src/TriggerGraphView.cpp 0.00% 10 Missing ⚠️
Viewer/ecflowUI/src/VInfo.cpp 0.00% 10 Missing ⚠️
Viewer/ecflowUI/src/VNode.hpp 0.00% 10 Missing ⚠️
Viewer/ecflowUI/src/VTree.cpp 0.00% 9 Missing ⚠️
Viewer/ecflowUI/src/AbstractNodeView.hpp 0.00% 7 Missing ⚠️
... and 206 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    49.27%   49.21%   -0.07%     
===========================================
  Files         1232     1232              
  Lines        97057    97655     +598     
  Branches     14868    14868              
===========================================
+ Hits         47828    48057     +229     
- Misses       49229    49598     +369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the task/adjust_PackConstructorInitializers_to_Never branch from e447356 to 4b750ff Compare January 29, 2026 13:06
IMHO, this provides a more readable & consistent source pattern
@marcosbento marcosbento force-pushed the task/adjust_PackConstructorInitializers_to_Never branch from 4b750ff to be3b3fe Compare January 29, 2026 13:40
@marcosbento marcosbento merged commit be3b3fe into develop Jan 29, 2026
135 of 136 checks passed
@marcosbento marcosbento deleted the task/adjust_PackConstructorInitializers_to_Never branch January 29, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants