Fix mirror unregistration ECFLOW-2058 #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A failure to de-register the client handle happens essentially every time the remote server is not available (e.g. has been shutdown, or is busy handling other requests), and is reported as an exception. This exception needs to be captured and handled to prevent the error from bubbling up and causing the server to terminate. Re ECFLOW-2058
This change allows to configure sub-second time periods between connection retries. Re ECFLOW-2058
This change allows to configure sub-second time periods for connection timeout. Re ECFLOW-2058
…r Mirror Re ECFLOW-2058
Re ECFLOW-2058
Re ECFLOW-2058
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #270 +/- ##
===========================================
+ Coverage 49.26% 49.28% +0.01%
===========================================
Files 1231 1232 +1
Lines 96996 97061 +65
Branches 14860 14868 +8
===========================================
+ Hits 47787 47834 +47
- Misses 49209 49227 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mirror unregistration was failing hard and causing an ecFlow server crash. These chances ensure the unregistration process is done in a safe manner, and networking issues are handled gracefully.
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-270