Skip to content

[GEF] Remove obsolete EditPartVisitor #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 1 commit into from
Jan 28, 2026
Merged

[GEF] Remove obsolete EditPartVisitor #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/EditPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
*******************************************************************************/
package org.eclipse.wb.gef.core;

import org.eclipse.wb.internal.gef.core.EditPartVisitor;

import org.eclipse.gef.EditPolicy;
import org.eclipse.gef.Request;
import org.eclipse.gef.commands.Command;
Expand Down Expand Up @@ -68,23 +66,6 @@ protected List<?> getModelChildren() {
return Collections.EMPTY_LIST;
}

////////////////////////////////////////////////////////////////////////////
//
// Visiting
//
////////////////////////////////////////////////////////////////////////////
/**
* Visits this {@link EditPart} and its children using given {@link EditPartVisitor}.
*/
public final void accept(EditPartVisitor visitor) {
if (visitor.visit(this)) {
for (EditPart childPart : (List<EditPart>) getChildren()) {
childPart.accept(visitor);
}
visitor.endVisit(this);
}
}

////////////////////////////////////////////////////////////////////////////
//
// EditPart
Expand Down
36 changes: 0 additions & 36 deletions org.eclipse.wb.core/src-gef/org/eclipse/wb/internal/gef/core/EditPartVisitor.java
View file
Open in desktop

This file was deleted.

14 changes: 4 additions & 10 deletions org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import org.eclipse.wb.internal.core.model.menu.IMenuObjectInfo;
import org.eclipse.wb.internal.core.model.menu.IMenuObjectListener;
import org.eclipse.wb.internal.core.model.menu.MenuObjectInfoUtils;
import org.eclipse.wb.internal.gef.core.EditPartVisitor;
import org.eclipse.wb.internal.gef.core.IActiveToolListener;

import org.eclipse.gef.EditPart;
Expand Down Expand Up @@ -206,16 +205,11 @@ public EditPart getTargetEditPart(org.eclipse.gef.Request request) {
public void run() {
try {
MenuObjectInfoUtils.m_selectingObject = m_object;
((org.eclipse.wb.gef.core.EditPart)getViewer().getRootEditPart()).accept(new EditPartVisitor() {
@Override
public boolean visit(EditPart editPart) {
if (editPart instanceof MenuObjectEditPart) {
editPart.refresh();
return false;
}
return true;
for (EditPart editPart : getViewer().getEditPartRegistry().values()) {
if (editPart instanceof MenuObjectEditPart) {
editPart.refresh();
}
});
}
} finally {
MenuObjectInfoUtils.m_selectingObject = null;
}
Expand Down
Loading