Skip to content

[GEF] Remove duplicate removeChild(EditPart) method #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 1 commit into from
Jan 28, 2026
Merged

[GEF] Remove duplicate removeChild(EditPart) method #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/EditPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,31 +174,6 @@ protected void refreshChildren() {
}
}

/**
* Removes a child <code>{@link EditPart}</code>. This method is called from
* {@link #refreshChildren()}. The following events occur in the order listed:
* <OL>
* <LI><code>deactivate()</code> is called if the child is active
* <LI>{@link EditPart#removeNotify()} is called on the child.
* <LI>The child's parent is set to <code>null</code>
* </OL>
* <P>
*/
protected final void removeChild(EditPart childPart) {
int index = getChildren().indexOf(childPart);
if (index == -1) {
return;
}
fireRemovingChild(childPart, index);
if (isActive()) {
childPart.deactivate();
}
childPart.removeNotify();
removeChildVisual(childPart);
getChildren().remove(childPart);
childPart.setParent(null);
}

/**
* Convenience method for returning the <code>{@link IEditPartViewer}</code> for this part.
*/
Expand Down
Loading