Skip to content

Conversation

@vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jan 28, 2026

What does this PR do?

Ensure that the SSH key Secret from the Workspace namespace contains the Include /etc/ssh/ssh_config.d/*.conf argument in the ssh_config value in its data. If the argument is not present in the Secret data, update the ssh_config value with the actual SSH Config.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8890

How to test this PR?

  1. Apply the che-server pull request image: quay.io/eclipse/che-server:pr-939.
  2. Add an SSH key to the user namespace.
  3. Check the SSH key content: the ssh_config value does not contain the Include /etc/ssh/ssh_config.d/*.conf argument.
  4. Start a workspace.
  5. Check the SSH key content: the ssh_config value contains the Include /etc/ssh/ssh_config.d/*.conf argument.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v19-gitea-no-pat-oauth-flow 199aa24 link true /test v19-gitea-no-pat-oauth-flow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants