Skip to content

Conversation

@vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jan 20, 2026

What does this PR do?

Ensure that the SSH key Secret from the Workspace namespace does not contain the ssh_config key in its data. If the key is present in the Secret data, remove it and create a dedicated git-ssh-config ConfigMap to mount SSH Config.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8890
eclipse-che/che-dashboard#1443

How to test this PR?

  1. Add an SSH key to the user namespace.
  2. Apply the related dashboard pull request image: quay.io/eclipse/che-dashboard:pr-1443.
  3. Apply the che-server pull request image: quay.io/eclipse/che-server:pr-.
  4. Start a workspace.
  5. See: workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2026

@vinokurig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v19-github-with-pat-setup-flow a9b3bb8 link true /test v19-github-with-pat-setup-flow
ci/prow/v19-bitbucket-no-pat-oauth-flow-ssh-url a9b3bb8 link true /test v19-bitbucket-no-pat-oauth-flow-ssh-url
ci/prow/v19-azure-with-pat-setup-flow a9b3bb8 link true /test v19-azure-with-pat-setup-flow
ci/prow/v19-gitlab-with-oauth-setup-flow a9b3bb8 link true /test v19-gitlab-with-oauth-setup-flow
ci/prow/v19-gitlab-no-pat-oauth-flow-ssh-url a9b3bb8 link true /test v19-gitlab-no-pat-oauth-flow-ssh-url
ci/prow/v19-gitea-no-pat-oauth-flow a9b3bb8 link true /test v19-gitea-no-pat-oauth-flow
ci/prow/v19-gitlab-with-pat-setup-flow a9b3bb8 link true /test v19-gitlab-with-pat-setup-flow
ci/prow/v19-azure-no-pat-oauth-flow-ssh-url a9b3bb8 link true /test v19-azure-no-pat-oauth-flow-ssh-url
ci/prow/v19-github-no-pat-oauth-flow-ssh-url a9b3bb8 link true /test v19-github-no-pat-oauth-flow-ssh-url

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants