Skip to content

Use numeric replica-group names #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bihan merged 1 commit into from
Jan 27, 2026
+12 −8
Merged

Use numeric replica-group names #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/dstack/_internal/core/models/configurations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from dstack._internal.core.models.services import AnyModel, OpenAIChatModel
from dstack._internal.core.models.unix import UnixUser
from dstack._internal.core.models.volumes import MountPoint, VolumeConfiguration, parse_mount_point
from dstack._internal.core.services import is_valid_dstack_resource_name
from dstack._internal.core.services import is_valid_replica_group_name
from dstack._internal.utils.common import has_duplicates, list_enum_values_for_annotation
from dstack._internal.utils.json_schema import add_extra_schema_types
from dstack._internal.utils.json_utils import (
Expand All @@ -55,7 +55,7 @@
DEFAULT_PROBE_READY_AFTER = 1
DEFAULT_PROBE_METHOD = "get"
MAX_PROBE_URL_LEN = 2048
DEFAULT_REPLICA_GROUP_NAME = "default"
DEFAULT_REPLICA_GROUP_NAME = "0"


class RunConfigurationType(str, Enum):
Expand Down Expand Up @@ -756,7 +756,7 @@ class ReplicaGroup(CoreModel):
name: Annotated[
Optional[str],
Field(
description="The name of the replica group. If not provided, defaults to 'replica-group-0', 'replica-group-1', etc. based on position."
description="The name of the replica group. If not provided, defaults to '0', '1', etc. based on position."
),
]
count: Annotated[
Expand Down Expand Up @@ -784,8 +784,8 @@ class ReplicaGroup(CoreModel):
@validator("name")
def validate_name(cls, v: Optional[str]) -> Optional[str]:
if v is not None:
if not is_valid_dstack_resource_name(v):
raise ValueError("Resource name should match regex '^[a-z][a-z0-9-]{1,40}$'")
if not is_valid_replica_group_name(v):
raise ValueError("Resource name should match regex '^[a-z0-9][a-z0-9-]{0,39}$'")
return v

@validator("count")
Expand Down Expand Up @@ -920,7 +920,7 @@ def validate_replicas(
# Assign default names to groups without names
for index, group in enumerate(v):
if group.name is None:
group.name = f"replica-group-{index}"
group.name = str(index)

# Check for duplicate names
names = [group.name for group in v]
Expand Down
4 changes: 4 additions & 0 deletions src/dstack/_internal/core/services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ def validate_dstack_resource_name(resource_name: str):

def is_valid_dstack_resource_name(resource_name: str) -> bool:
return re.match("^[a-z][a-z0-9-]{1,40}$", resource_name) is not None


def is_valid_replica_group_name(name: str) -> bool:
return re.match("^[a-z0-9][a-z0-9-]{0,39}$", name) is not None
4 changes: 2 additions & 2 deletions src/tests/_internal/server/routers/test_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def get_dev_env_run_plan_dict(
"replica_num": 0,
"job_num": 0,
"jobs_per_replica": 1,
"replica_group": "default",
"replica_group": "0",
"single_branch": False,
"max_duration": None,
"stop_duration": 300,
Expand Down Expand Up @@ -494,7 +494,7 @@ def get_dev_env_run_dict(
"replica_num": 0,
"job_num": 0,
"jobs_per_replica": 1,
"replica_group": "default",
"replica_group": "0",
"single_branch": False,
"max_duration": None,
"stop_duration": 300,
Expand Down