Skip to content

Conversation

@donbr
Copy link
Owner

@donbr donbr commented Nov 5, 2025

Summary

Updates dropout rate from <5% to <10% to align with the 90%+ retention rate mentioned throughout the site.

Problem

The site mentions "90%+ retention rate" but also claimed "<5% dropout rate" which would imply 95%+ retention. This inconsistency needed to be resolved.

Solution

Updated both occurrences of "<5% dropout rate" to "<10% dropout rate" to maintain consistency:

  • 90% retention = 10% dropout ✓
  • Still an impressive achievement (vs. 20-30% industry average)

Changes

Updated in src/pages/HomePage.tsx:

  1. Line 91 - The Journey section: "Teaching 100+ engineers... with a <10% dropout rate"
  2. Line 284 - Teaching & Mentorship section: "Consistently Lowest Dropout Rate: <10%"

Test Plan

  • Build succeeds without warnings
  • Text updates correctly displayed
  • Messaging now consistent across all metrics

This ensures all teaching impact metrics are aligned and accurate.

🤖 Generated with Claude Code

Aligns dropout rate with the 90%+ retention rate mentioned throughout the site.
This ensures consistent messaging about teaching impact and student success metrics.

Changed in two locations:
- The Journey section: "Teaching 100+ engineers... with a <10% dropout rate"
- Teaching & Mentorship section: "Consistently Lowest Dropout Rate: <10%"

This maintains the impressive achievement while being consistent with the
90%+ retention rate claim (90% retention = <10% dropout).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link

claude bot commented Nov 5, 2025

Pull Request Review - PR #5: Fix Dropout Rate Consistency

Overall Assessment: APPROVED

This is a well-executed, focused fix that resolves a mathematical inconsistency in the portfolio site's teaching metrics.


Code Quality & Best Practices

Strengths:

  1. Mathematically Correct: The change properly aligns the dropout rate with the stated 90%+ retention rate

    • 90% retention = 10% dropout
    • Fixes the previous inconsistency where <5% dropout would imply 95%+ retention
  2. Consistent Application: Both occurrences updated correctly:

    • Line 91 (The Journey section)
    • Line 284 (Teaching & Mentorship section)
  3. Proper HTML Encoding: Uses &lt; for the less-than symbol, maintaining correct HTML entity usage

  4. Minimal, Focused Change: Only touches what's necessary (2 additions, 2 deletions)

  5. Well-Documented PR: Clear summary, problem statement, and test plan in PR description


Verification of Consistency

I verified all mentions of retention/dropout metrics across the codebase:

  • Line 33: "90%+ student retention rate" (quote in hero)
  • Lines 68-69: "90%+" retention metric badge
  • Line 91: "<10% dropout rate" (updated)
  • Line 284: "<10% dropout rate" (updated)

All metrics are now mathematically aligned and consistent across the entire page.


Testing & Build

The PR description indicates:

  • Build succeeds without warnings
  • Text updates correctly displayed
  • Messaging now consistent across all metrics

Recommendation: Consider verifying the build succeeds by running npm run build


Performance Considerations

No Performance Impact: This is a text-only change with zero performance implications.


Security Concerns

No Security Issues:

  • Proper HTML entity encoding maintained
  • No XSS vulnerabilities introduced
  • No external dependencies added

Potential Improvements (Optional)

While not required for this PR, consider these enhancements for the future:

  1. Constants for Metrics: Extract retention/dropout rates into constants to prevent future inconsistencies
  2. Automated Validation: Add a simple test to ensure dropout + retention = 100%
  3. Typography Component: Consider using a reusable component for metric displays to ensure consistency

Summary

Verdict: Ready to Merge

This PR successfully:

  • Fixes a mathematical inconsistency
  • Maintains code quality standards
  • Applies changes consistently
  • Follows proper HTML encoding practices
  • Includes clear documentation

The change is accurate, well-scoped, and ready for production. Great attention to detail in catching this inconsistency!


Reviewed by: Claude Code
Review Date: 2025-11-05

@donbr donbr merged commit bef8dcf into main Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants