-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: New cli for labpdfproc #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d with _create_args
|
@sbillinge This is ready for review/discussion if you find some time this weekend. Im marking this as a draft for now so i can come back monday with a clearer head. Also the merge conflict looks to be because of some re-skpkging work. Just wanted to get this to you if you have any comments. |
|
I looked through the commands and they look great. I like everything you did here. |
|
Closing because of merge conflicts. Couldn't figure out how to resolve them and didn't want to lose everything |
I wanted to get this PR in before the weekend, so apologies for the sloppy commits. This PR improves the UX of labpdfproc. It breaks it into 3 subcommands
mud,zscan, andsample. These commands do the followingmudcommandzscancommandsamplecommandAll commands have the same following options
Additional changes
--anode-typeand merged it with--wavelength. If the user wants to specify an anode type, they still can. They just use the--wavelengthoption (ie--wavelength Mo) and the code recognizes this. I felt as if this made the code smoother.Gooey interface
With this change, the gui now is separated nicely into its three subcommands.
