misc: Tweak importing of ctypes.utils in archinfo.py #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDBetteridge
requested changes
Jan 20, 2026
| import re | ||
| import sys | ||
| from contextlib import suppress | ||
| from ctypes import util as ctypesutil |
Contributor
There was a problem hiding this comment.
Suggested change
| from ctypes import util as ctypesutil | |
| import ctypes.util |
Contributor
There was a problem hiding this comment.
(and then you can drop the other changes)
Contributor
Author
There was a problem hiding this comment.
Oh interesting. I was doing it this way so there wasn't a nondescript util floating around, although I guess you are a fan of those
Contributor
There was a problem hiding this comment.
There isn't, it still needs to be referenced as ctypes.util. I see your point, but there's not much I can do about a Python internal library 🤷
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
- Coverage 78.98% 78.96% -0.02%
==========================================
Files 248 248
Lines 50815 50816 +1
Branches 4391 4391
==========================================
- Hits 40134 40129 -5
- Misses 9879 9883 +4
- Partials 802 804 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.