Skip to content

disabled prop should return condition when string, otherwise False #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hameye merged 2 commits into from
Sep 17, 2025
Merged

disabled prop should return condition when string, otherwise False #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3de22c
#46 disabled prop should return condition when string, otherwise False
theweaklink Sep 15, 2025
4fe4e36
update changelog
theweaklink Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelogs/1.2.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
:octicons-issue-opened-24: Issue Ref | :fontawesome-solid-thumbtack: Summary | :material-message-text: Description
-|-|-
[No Ref] | Fix `csv_reader` documentation | Fix wrong parameter in `csv_reader` example documentation.
[#46] | input elements are disabled when optional is True | Bug was causing the element to be disabled permanently when optional.


## Enhancements
Expand Down
2 changes: 1 addition & 1 deletion onecode/elements/input_element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def disabled(self) -> Union[bool, str]:
The element disabling condition.

"""
return self._disabled
return self._disabled if isinstance(self._disabled, str) else False

@property
def hide_when_disabled(self) -> bool:
Expand Down
Loading