Skip to content

Conversation

@HenrikHL
Copy link
Contributor

@HenrikHL HenrikHL commented Jan 28, 2026

User description

SD-2816: Add CSR (Carrier customer service representative) to partyFunction values


PR Type

Enhancement


Description

  • Add CSR (Carrier customer service representative) to partyFunction enum values

  • Update OpenAPI specification with new party function option


Diagram Walkthrough

flowchart LR
  A["partyFunction enum"] -- "add CSR option" --> B["Updated enum values"]
  B -- "includes" --> C["CSR: Carrier customer service representative"]
Loading

File Walkthrough

Relevant files
Enhancement
BKG_v2.0.4.yaml
Add CSR to partyFunction enum values                                         

bkg/v2/BKG_v2.0.4.yaml

  • Added CSR (Carrier customer service representative) to the
    partyFunction enum values in OtherDocumentParty component
  • New enum option appears alongside existing options like DDS, N2, NI,
    and NAC
+2/-0     
Configuration changes
styleguide.json
Styleguide configuration updates                                                 

.stoplight/styleguide.json

  • Minor configuration or styling updates
+1/-1     

@HenrikHL HenrikHL requested a review from Copilot January 28, 2026 12:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the CSR (Carrier customer service representative) party function option to the OpenAPI specification for BKG v2.0.4, expanding the available party function types that can be used in booking operations.

Changes:

  • Added CSR enum value to the partyFunction property in the OtherDocumentParty schema

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #SD-2816
🟢 Update the API/schema documentation (allowed values list / OpenAPI spec) to include CSR
for partyFunction in “Other Document Party”.
🔴 Add new party function code CSR (Carrier customer service representative) under
documentParties.other for Booking request.
Add new party function code CSR (Carrier customer service representative) under
documentParties.other for Booking confirmation.
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Update example to CSR

Update the example value to CSR to reflect the newly added enum option.

bkg/v2/BKG_v2.0.4.yaml [4478]

-example: DDS
+example: CSR
  • Apply / Chat
Suggestion importance[1-10]: 4

__

Why: This is a good suggestion for improving documentation quality by updating the example to use the newly added CSR enum value, but it has a low impact on functionality.

Low
  • More

@HenrikHL HenrikHL merged commit 366b1f1 into master Jan 28, 2026
1 check passed
@HenrikHL HenrikHL deleted the SD-2816_add-CSR-partyFunction branch January 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants