-
Notifications
You must be signed in to change notification settings - Fork 16
EBL 3.0: SD-2793: Update API description #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the API documentation to reflect a refactoring of the documentParties structure from an array to an object with specific properties. The changes clarify how different types of eBL documents are represented, particularly for blank-endorsed and to-order/negotiable eBLs.
Changes:
- Updated documentation to reference
documentPartiesas an object rather than an array - Removed incorrect references to
partyFunctioncodeEND(Endorsee) - Clarified that the endorsee is represented as a specific object property rather than an array element with a particular party function code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
User description
SD-2793: Improve PINT API description
Removes wrong reference to
ENDpartyFuntionCode as DocumentParties now have specific party objectsPR Type
Documentation
Description
Updates API documentation to reflect DocumentParties structure changes
Replaces array notation with object notation for documentParties references
Removes incorrect references to partyFunction
ENDcodeClarifies endorsee party as specific object instead of array element
Diagram Walkthrough
File Walkthrough
EBL_PINT_v3.0.0.yaml
Clarify DocumentParties structure in eBL type descriptionspint/v3/EBL_PINT_v3.0.0.yaml
documentPartiesobject instead of array withpartyFunctionENDcodereference
endorseedocument party object instead of array element withENDcodedocumentParties[](array notation) todocumentParties(object notation)rather than an array element