Skip to content

Conversation

@mcruzdev
Copy link
Contributor

Description

Add a new method in WorkflowRuntime class, allowing a shutdown "now" approach.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1631

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev force-pushed the durable-task-close-now branch from e1c4d90 to 6094775 Compare January 29, 2026 12:04
@mcruzdev mcruzdev changed the title Introduce closeNow() for Introduce closeNow() to allow a "now" shutdown Jan 29, 2026
@mcruzdev mcruzdev marked this pull request as ready for review January 29, 2026 12:05
@mcruzdev mcruzdev requested review from a team as code owners January 29, 2026 12:05
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.89%. Comparing base (02fa2c8) to head (6094775).

Files with missing lines Patch % Lines
...ava/io/dapr/workflows/runtime/WorkflowRuntime.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1632      +/-   ##
============================================
- Coverage     78.95%   78.89%   -0.06%     
- Complexity     2093     2094       +1     
============================================
  Files           228      228              
  Lines          6309     6312       +3     
  Branches        693      693              
============================================
- Hits           4981     4980       -1     
- Misses          976      981       +5     
+ Partials        352      351       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to use shutdown now then closing a WorkflowRuntime

1 participant