-
Notifications
You must be signed in to change notification settings - Fork 224
Upgrade Protobuf versiont to 4.x.x #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade Protobuf versiont to 4.x.x #1611
Conversation
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
|
Integration tests are failing due to flaky test #1603 |
|
@dapr/approvers-java-sdk / @dapr/maintainers-java-sdk PR ready for review. Thank you Update Protobof version to 4.33.2 (latest) |
|
@siri-varma I am worried about doing this, because we the grpc netty libraries also depend on Protobuf. As far as I remember we upgraded to the version that was aligned with Spring Boot and the versions used by the Spring Boot Otel instrumentation that also uses GRPC. I wouldn't upgrade this unless we are also upgrading those dependencies. Can you check which dependencies depend on protobuf by running |
salaboy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I can approve this unless we check which transitive dependencies also depend on this.
Signed-off-by: siri-varma <siri.varma@outlook.com>
…/siri-varma/java-sdk into users/svegiraju/upgrade-protobuf
|
Hello @javier-aliaga ! Just wanted to check with you on this. Thank you. |
|
Hello @javier-aliaga ! Just wanted to bump this up again |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1611 +/- ##
=========================================
Coverage 78.95% 78.95%
Complexity 2093 2093
=========================================
Files 228 228
Lines 6309 6309
Branches 693 693
=========================================
Hits 4981 4981
Misses 976 976
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Upgraded the Protobuf version to 4.x
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1590
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: