Skip to content

Partial fix for #14342 FN containerOutOfBounds with std::span and std::string_view (regression) #8164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Partial fix for #14342 FN containerOutOfBounds with std::span and std::string_view (regression) #8164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3649446
Update valueflow.cpp
chrchr-github Jan 28, 2026
7de5296
Update teststl.cpp
chrchr-github Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6504,10 +6504,12 @@ static std::vector<ValueFlow::Value> getContainerSizeFromConstructorArgs(const s
return {};
}

static bool valueFlowIsSameContainerType(const ValueType& contType, const Token* tok, const Settings& settings)
static bool valueFlowIsSameContainerType(const ValueType& contType, const Token* tok, bool isView, const Settings& settings)
{
if (!tok || !tok->valueType() || !tok->valueType()->containerTypeToken)
if (!tok || !tok->valueType())
return true;
if (!tok->valueType()->containerTypeToken)
return !isView;

const ValueType tokType = ValueType::parseDecl(tok->valueType()->containerTypeToken, settings);
return contType.isTypeEqual(&tokType) || tokType.type == ValueType::Type::UNKNOWN_TYPE;
Expand Down Expand Up @@ -6536,7 +6538,7 @@ static std::vector<ValueFlow::Value> getInitListSize(const Token* tok,
initList = true;
else if (vt.isIntegral() && astIsIntegral(args[0], false))
initList = true;
else if (args.size() == 1 && valueFlowIsSameContainerType(vt, tok->astOperand2(), settings))
else if (args.size() == 1 && valueFlowIsSameContainerType(vt, tok->astOperand2(), valueType->container->view, settings))
initList = false; // copy ctor
else if (args.size() == 2 && (!args[0]->valueType() || !args[1]->valueType())) // might be unknown iterators
initList = false;
Expand Down
8 changes: 8 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,14 @@ class TestStl : public TestFixture {
"bool g() { return f(\" \"); }\n");
ASSERT_EQUALS("[test.cpp:1:44]: error: Out of bounds access in 's[500]', if 's' size is 1 and '500' is 500 [containerOutOfBounds]\n",
errout_str());

checkNormal("int main() {\n" // #14342
" const int a[] = { 1, 2, 3 };\n"
" std::span<const int> x{ a };\n"
" return x[3];\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4:13]: error: Out of bounds access in 'x[3]', if 'x' size is 1 and '3' is 3 [containerOutOfBounds]\n",
errout_str());
}

void outOfBoundsSymbolic()
Expand Down
Loading