Add fully qualified name support for nested classes/modules #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement compact representation for qualified names (e.g., Api::V1::User)
using SmallVec to minimize heap allocations - up to 16 segments stored
inline on stack.
## Changes
### Type System (types.rs)
- Add QualifiedName struct with compact representation
- Single String for full name + SmallVec<[u16; 16]> for segment offsets
- O(1) operations: name(), parent(), child()
- Only 1 heap allocation regardless of nesting depth
- Update Type enum: class_name -> name: QualifiedName
- Add Type::instance() and Type::singleton() constructors
### AST Parsing (definitions.rs)
- Add extract_constant_path() to handle ConstantPathNode recursively
- Support both simple names (User) and qualified names (Api::V1::User)
### Scope Management (scope.rs)
- Add current_qualified_name() method
- Traverse scope chain to build fully qualified name from nested scopes
### Other Updates
- Update install_self() to use qualified names
- Migrate all Type::Instance { class_name } usages to Type::instance()
- Add comprehensive tests (127 total)
dak2
force-pushed
the
support-nested-class
branch
from
c95de38 to
e06a001
Compare
dak2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement compact representation for qualified names (e.g., Api::V1::User)
using SmallVec to minimize heap allocations - up to 16 segments stored
inline on stack.
Changes
Type System (types.rs)
AST Parsing (definitions.rs)
Scope Management (scope.rs)
Other Updates