fix(errorprone): address warnings after plugin update #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align overrides, locale usage, and type checks to keep diagnostics clean without behavior changes.
Tighten guard checks, mkdir conditions, and loopback resolution to satisfy Error Prone without behavior changes.
Use value equality for routed reject specs and peer source matching to align with error-prone guidance.
Use explicit compatibility codes and status ordering without ordinal reliance in client and FCP serialization paths.
Use java.time for alert feed timestamps and suppress legacy Date usage where APIs still require it.
Tighten request tag comparisons and update UIDTag Javadocs to satisfy Error Prone without behavior changes.
Use value equality for message specs, add overrides, and simplify conditionals to satisfy Error Prone guidance.
Introduce explicit ConnectionType codes and use value equality for opennet completion messages to avoid ordinal reliance.
Reduce warning noise without behavior changes.
Reduce warning noise via locale-safe casing and small cleanups.
Reduce warning noise in auth parsing helpers.
Remove unnecessary TimeUnit conversion.
Use AddressTracker.Status to reduce ambiguity.
Remove redundant parentheses in key search.
Reduce warning noise in send/drop logic and update backoff.
Reduce warning noise in port alerts and IP fallback.
Use expression/rule switch for gating and NAT counts.
Reduce Error Prone warnings in packet handling by using array-backed lists and explicit precedence.
Reduce JdkObsolete warnings by using ArrayDeque for bounded nonce storage.
Reduce JdkObsolete warnings by returning packet indices in an ArrayDeque.
Reduce UnnecessaryParentheses warnings in packet encoding.
Remove unnecessary parentheses in resent bit packing.
Reduce Error Prone findings by using ArrayList, simplifying expressions, and using identity hash.
Reduce JdkObsolete warnings by using array-backed collections and add a missing override for the dispatcher run loop.
Reduce JdkObsolete warnings by using ArrayList-backed collections for queue tracking.
Refresh verification metadata for updated plugin artifacts.
Avoid JdkObsolete warnings from LinkedList usage in Ogg page sizing.
Avoid JdkObsolete LinkedList usage in node composition.
Annotate HTTP handlers and availability checks with @OverRide to match interface contracts.
Use StandardCharsets in test helpers to avoid DefaultCharset warnings.
Use long literals directly to avoid IntLiteralCast warnings.
Simplify access checks, use value equality for bookmarks, and suppress array record warnings.
Suppress Date usage where required and avoid logging PageMaker identities in queue diagnostics.
Make output decoding explicit, simplify percentage literals, and rethrow reflective failures as LinkageError.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing