Skip to content

Conversation

@bobh66
Copy link
Collaborator

@bobh66 bobh66 commented Jan 23, 2026

Description of your changes

Add a check in the function runner to detect coroutines for compose() and operate() and await them accordingly.

Fixes #44

I have:

@bobh66 bobh66 requested a review from negz January 23, 2026 02:59
@bobh66 bobh66 force-pushed the add_async_support branch from 30bfc20 to 98b8787 Compare January 23, 2026 03:03
@bobh66 bobh66 mentioned this pull request Jan 23, 2026
1 task
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Would it make sense to explain briefly when to use async and when not to in the README?

Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
@bobh66 bobh66 force-pushed the add_async_support branch from 98b8787 to f3066d6 Compare January 23, 2026 21:59
@bobh66
Copy link
Collaborator Author

bobh66 commented Jan 23, 2026

Nice, thank you!

Would it make sense to explain briefly when to use async and when not to in the README?

I'm not sure there is ever a reason not to use async, but I updated the README with some reasons to use it. It won't help if the script isn't await'ing anything, but it won't hurt either.

@bobh66 bobh66 changed the title Add support for async compose and operatoe functions. Add support for async compose and operate functions. Jan 23, 2026
@bobh66 bobh66 merged commit 0868df3 into crossplane-contrib:main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for async compose and operator functions

2 participants