Панин Максим #13
Closed
Панин Максим #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czertyaka
requested changes
Dec 8, 2024
src/two-sum.cpp
Outdated
| @@ -0,0 +1,39 @@ | |||
| #include <iostream> | |||
| #define ARRAY_SIZE 5 | |||
Collaborator
There was a problem hiding this comment.
Можно подключить заголовочный файл two-sum.hpp и не дублировать определение макроса
src/two-sum.cpp
Outdated
| @@ -0,0 +1,39 @@ | |||
| #include <iostream> | |||
Collaborator
There was a problem hiding this comment.
Заголовочный файл не используется
src/two-sum.cpp
Outdated
| std::size_t& index1 | ||
| ) | ||
| { | ||
| unsigned int kolvo_par = 0; |
Collaborator
There was a problem hiding this comment.
Зачем считаете количество пар? По условию задачи подойдет любая пара
src/two-sum.cpp
Outdated
| bool proverka_par = false; | ||
| for (unsigned int i = 0; i <= ARRAY_SIZE - 1; i++) | ||
| { | ||
| for (unsigned int j = i + 1; j <= ARRAY_SIZE; j++) |
Collaborator
There was a problem hiding this comment.
Условие должно быть < ARRAY_SIZE. Сейчас имеем выход за границы массива, что показывают тесты
czertyaka
requested changes
Dec 15, 2024
src/two-sum.cpp
Outdated
| { | ||
| for (unsigned int i = 0; i < ARRAY_SIZE; i++) | ||
| { | ||
| for (unsigned int j = i + 1; j <= ARRAY_SIZE; j++) |
Collaborator
There was a problem hiding this comment.
В этой строке все еще условие неверно
Если я всё правильно понял, то ошибка в том что я забыл что счёт идёт с 0, и до 5(ARRAY_SIZE) будет всего 6 чисел, а не 5, как должно быть
Collaborator
|
Задание принято |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.