Re-execute itself with DYLD_LIBRARY_PATH #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After libkrun stopped linking directly against libkrunfw, we depend on dlopen() and the system's linker to do a sane job at looking for the library. This poses a problem on macOS, since the library path from the brew prefix is not used for looking up libraries by default. So work around this limitation, look if the DYLD_LIBRARY_PATH environment variable is present. If it isn't, obtain the brew prefix and re-execute krunvm with pushing that variable with brew's library path into the list of environment variables. Fixes: containers#70 Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
force-pushed
the
macos-workaround-dyld
branch
from
9da3368 to
8ad6319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After libkrun stopped linking directly against libkrunfw, we depend on dlopen() and the system's linker to do a sane job at looking for the library. This poses a problem on macOS, since the library path from the brew prefix is not used for looking up libraries by default.
So work around this limitation, look if the DYLD_LIBRARY_PATH environment variable is present. If it isn't, obtain the brew prefix and re-execute krunvm with pushing that variable with brew's library path into the list of environment variables.
Fixes: #70