-
Notifications
You must be signed in to change notification settings - Fork 20
[APIE-693] Add support for pool scoped role bindings #3218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…oper role binding
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for managing FlinkDeveloper role bindings scoped to Flink compute pools by introducing a new --flink-region flag. The flag accepts values in the format cloud.region (e.g., aws.us-east-1) and incorporates this into the CRN pattern for pool-scoped role bindings.
Key Changes:
- Added
--flink-regionflag toiam rbac role-bindingcommands (create, delete, list) - Updated CRN pattern parsing logic to include flink-region when specified
- Added test coverage for the new FlinkDeveloper compute pool binding functionality
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/iam/command_rbac_role_binding.go | Added flink-region flag and CRN pattern parsing logic |
| internal/iam/command_rbac_role_binding_create.go | Added example usage for FlinkDeveloper with compute pool |
| internal/iam/command_rbac_role_binding_list.go | Added flink-region flag to list command |
| test/test-server/iam_handlers.go | Added test data for FlinkDeveloper compute pool binding |
| test/iam_test.go | Added integration tests for create and list operations |
| test/fixtures/output/iam/rbac/role-binding/*.golden | Updated help text and added expected outputs for new functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.




Release Notes
Breaking Changes
New Features
--flink-regionflag forconfluent iam rbac role-binding [create | delete | list]to manageFlinkDeveloperbindings with compute pool resourcesBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add Cloud support for binding the
FlinkDeveloperrole to compute pools. The CRN pattern for this binding requires the Flink region, so this PR adds a new--flink-regionflag taking arguments of the formcloud.region(e.g.aws.us-east-1) so that the CLI is able to include this in the CRN.Blast Radius
This is an additive change so the blast radius is minimal.
References
Test & Review
https://docs.google.com/document/d/1G3BfuxE8fj11VfpIMC7U5ZR_UvllEYuNK6poMzPQdgc/edit?usp=sharing