Limit core-unittests Checkstyle scope and allow empty {} method/constructor bodies

[shai-almog]

Motivation

• Checkstyle for maven/core-unittests was applying to test sources and flagged empty method/constructor bodies written as {}, so the configuration should be limited to the CodenameOne source tree and permit empty bodies.

Description

• Set <includeTestSourceDirectory>false> in maven/core-unittests/pom.xml so Checkstyle only analyzes the configured sourceDirectory (${src.dir}) and not test or other module sources.
• Update maven/core-unittests/checkstyle.xml to add allowEmptyMethods=true and allowEmptyConstructors=true to the WhitespaceAround module so {} bodies are accepted.

Testing

• No automated tests or CI jobs were run for this change.

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2283 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.80% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ✅ SpotBugs: 0 findings (no issues) [Report archive]
• ❌ PMD: 71 findings (P3: 63, P4: 8) [HTML preview] [Download]
  • Top findings
    • P3: CodenameOne/src/com/codename1/ads/InnerActive.java:43 – This final field could be made static (rule: FinalFieldCouldBeStatic)
    • P3: CodenameOne/src/com/codename1/annotations/Async.java:19 – Class cannot be instantiated and does not provide any static methods or fields (rule: MissingStaticMethodInNonInstantiatableClass)
    • P3: CodenameOne/src/com/codename1/charts/compat/PathMeasure.java:36 – Perhaps 'forceClosed' could be replaced by a local variable. (rule: SingularField)
    • P3: CodenameOne/src/com/codename1/components/Accordion.java:225 – Use opposite operator instead of the logic complement operator. (rule: LogicInversion)
    • P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1323 – Unnecessary semicolon (rule: UnnecessarySemicolon)
    • …and 66 more
• ❌ Checkstyle: 405 findings (Error: 405) [HTML preview] [Download]
  • Top findings
    • Error: CodenameOne/src/com/codename1/javascript/JSFunction.java:1 – File does not end with a newline. (rule: NewlineAtEndOfFileCheck)
    • Error: CodenameOne/src/com/codename1/javascript/JSException.java:1 – File does not end with a newline. (rule: NewlineAtEndOfFileCheck)
    • Error: CodenameOne/src/com/codename1/components/Switch.java:368:15 – Line contains a tab character. (rule: FileTabCharacterCheck)
    • Error: CodenameOne/src/com/codename1/components/Switch.java:752:48 – ';' is not followed by whitespace. (rule: WhitespaceAfterCheck)
    • Error: CodenameOne/src/com/codename1/components/Switch.java:995:24 – ',' is not followed by whitespace. (rule: WhitespaceAfterCheck)
    • …and 400 more

Generated automatically by the PR CI workflow.