fix(worker): Route bundle analysis tasks to enterprise queues #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle analysis tasks (processor, notify, save_measurements) were not being routed to enterprise queues because they were missing from the task router's lookup functions. This adds them to both _get_ownerid_from_task and _get_user_plan_from_task mappings. Also fixes missing lock_timeout parameter in bundle analysis tasks' LockManager initialization.
The lock_timeout parameter was causing test failures because self.hard_time_limit_task is a MagicMock in integration tests, and max() cannot compare MagicMock with int. The routing changes are preserved - only the unrelated lock_timeout addition is reverted.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 1292 1292
Lines 47128 47128
Branches 1567 1567
=======================================
Hits 43996 43996
Misses 2823 2823
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle analysis tasks (
bundle_analysis_processor,bundle_analysis_notify,bundle_analysis_save_measurements) were not being routed to enterprise queues because they were missing from the task router's lookup functions.Changes
_get_ownerid_from_taskmapping incelery_task_router.py_get_user_plan_from_taskmapping incelery_task_router.pylock_timeoutparameter inBundleAnalysisNotifyTaskandBundleAnalysisProcessorTaskLockManager initializationTest Plan
_get_user_plan_from_taskreturns correct plan for bundle analysis tasks_get_ownerid_from_taskreturns correct owner for bundle analysis tasksLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Ensures bundle analysis tasks route using repo-based owner/plan lookups so enterprise repos are sent to enterprise queues.
_get_ownerid_from_taskand_get_user_plan_from_taskmappings incelery_task_router.pybundle_analysis_processor,bundle_analysis_notify, andbundle_analysis_save_measurementsWritten by Cursor Bugbot for commit 93b2946. This will update automatically on new commits. Configure here.