Fix systemic service detection issues across all frameworks #1154
+39
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comprehensive fix addresses root causes reported in issue #1152, affecting not just PostgreSQL but 6 additional frameworks. CORE LIBRARY FIXES (src/java/common/context.go): 1. HasService() - Now case-insensitive - Handles service label variations (PostgreSQL vs postgresql) - Affects 19+ frameworks automatically 2. HasTag() - Now case-insensitive - Handles tag casing variations across service brokers - Affects 19+ frameworks automatically 3. HasServiceByNamePattern() - Now searches ALL service labels - Fixes broker-provided service detection (postgresql, mysql, etc.) - Was limited to 'user-provided' only - Affects 19+ frameworks automatically FRAMEWORK-SPECIFIC FIXES: 4. PostgreSQL JDBC - Use centralized ContainsIgnoreCase helper 5. MariaDB JDBC - Use centralized ContainsIgnoreCase helper 6. Elastic APM Agent - Simplified detection logic, use helpers consistently 7. Luna Security Provider - Use centralized ContainsIgnoreCase helper 8. ProtectApp Security Provider - Use centralized ContainsIgnoreCase helper 9. Seeker Security Provider - Use centralized ContainsIgnoreCase helper BENEFITS: - Single fix point for case-insensitive matching - Consistent behavior across all 25+ frameworks - Eliminates code duplication - More robust detection for various service broker conventions Supersedes PR #1153 with comprehensive systemic fix. Fixes #1152
Contributor
|
@ramonskie great to have adjusted the frameworks service detection! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR comprehensively fixes the root causes reported in issue #1152, affecting not just PostgreSQL but 6 additional frameworks.
Supersedes: #1153 (provides more comprehensive fix)
Fixes: #1152
Problem
Service detection was broken in two ways:
HasServiceByNamePattern()only searched "user-provided" services, missing broker-provided servicesSolution
Core Library Fixes (
src/java/common/context.go)HasService()- Now case-insensitive, iterates all service labels (affects 19+ frameworks automatically)HasTag()- Now case-insensitive tag comparison (affects 19+ frameworks automatically)HasServiceByNamePattern()- Now searches ALL service labels, not just "user-provided" (affects 19+ frameworks automatically)Framework-Specific Fixes (6 frameworks)
Standardized to use
common.ContainsIgnoreCase()helper:Testing
Impact