Fix/udev rules persistance of network interfaces #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing a file to overwrite the 70-persistent-net.rules if existing or adding if not existent
Dany9966
requested changes
Jan 29, 2026
| coriolis_udev_rules_file = "etc/udev/rules.d/99-coriolis-net.rules" | ||
| if net_ifaces_info: | ||
| content = utils.get_udev_net_rules(net_ifaces_info) | ||
| if not self._test_path(udev_file): |
Contributor
There was a problem hiding this comment.
We don't need to write to the original file anymore, we can simply use the custom one. Please write directly to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version does not handle the case of already existing
etc/udev/rules.d/70-persistent-net.rules, so this case will add the fileetc/udev/rules.d/99-coriolis-net.rulesthat will overwrite those configurations and apply them for the interfaces.