Remove enable_repo from osmorphing for all redhat based OSes #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabi200123
force-pushed
the
ol-enable-repo
branch
from
622b1aa to
357358c
Compare
Dany9966
reviewed
Jan 20, 2026
| try: | ||
| yum_cmd = 'yum install %s -y%s' % ( | ||
| " ".join(package_names), | ||
| "".join([" --enablerepo=%s" % r for r in enable_repos])) |
Contributor
There was a problem hiding this comment.
Please don't remove this flag from the command, as we may need it in some cases. We want to only remove the _find_yum_repos logic, which always runs. But the flag itself may prove itself useful on special cases (we'll have to look for what those special cases are in the providers).
fabi200123
force-pushed
the
ol-enable-repo
branch
from
357358c to
b905f06
Compare
fabi200123
force-pushed
the
ol-enable-repo
branch
4 times, most recently
from
5ed082d to
a1d03f9
Compare
Contributor
|
PR and commit message nit: the enablerepo is removed for all redhat based OSes, not just Oracle Linux. |
fabi200123
changed the title
fabi200123
force-pushed
the
ol-enable-repo
branch
from
a1d03f9 to
3421899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the following:
--enablerepofrom theyum installcommand for Oracle Linux