Commit reconciliation request #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re cascading of rename to triangle.columns_label.
…st jupyter notebooks.
…r copy that had the previous ordering. Closes casact#667.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 85 85
Lines 4883 4883
Branches 626 626
=======================================
Hits 4151 4151
Misses 522 522
Partials 210 210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kennethshsu
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @kennethshsu, I've got that weird situation going on where I'm getting notified that my fork is 20-something commits ahead even though almost all these changes were merged in yesterday.
Could you please do me a favor and approve this PR (it has a mostly meaningless 1-character change), but let me merge and close it myself? I think the last time I did this, the issue cleared up, but if it doesn't, I'll do a hard reset on my own fork. Regardless, I won't commit to my own main branch after this to avoid the situation going forward.