fix: Nebius ListInstances pagination #77
Merged
+45
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if len(response.Items) > 0 { | ||
| c.logger.Info(ctx, "found instances in project", |
Contributor
There was a problem hiding this comment.
nonblocking: should we make this debug?
patelspratik
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our implementation of ListInstances for Nebius, we cycle through each region and call List(...) from the Nebius SDK to list all VMs in that region. We were not paginating this call, and it turns out the default page size it 10, so all VMs after the first 10 listed are assumed to be terminated. This PR updates the page size to 100 and introduces pagination.