feat(boxsdk): shared network client and token storage #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsocha2
changed the title
Pask423
requested changes
Jan 20, 2026
| Note: This will call store_tokens with None values if the callback supports it. | ||
| """ | ||
| if self._store_tokens is not None: |
Contributor
There was a problem hiding this comment.
in python checking a is None is preferred over a ==None
| response_object=box_response.json(), | ||
| ) | ||
|
|
||
| def get_authentication(self, *, token_storage=None): |
Contributor
There was a problem hiding this comment.
missing typehint for token_storage and returned type
|
|
||
| # Developer Token Authentication | ||
| if isinstance(oauth, DeveloperTokenAuth): | ||
| token = oauth.access_token |
Contributor
There was a problem hiding this comment.
maybe extract if body to separate private methods for better readability
| to a generated SDK Authentication object. | ||
| This method supports the following legacy authentication types: | ||
| - DeveloperTokenAuth -> BoxDeveloperTokenAuth |
| oauth._store_tokens(access_token, refresh_token) | ||
|
|
||
| token_storage = LegacyTokenStorageAdapter( | ||
| get_tokens=get_tokens, store_tokens=store_tokens |
| # Pre-populate with existing tokens if available | ||
| auth = BoxOAuth(config=config) | ||
| access_token, refresh_token = oauth._get_tokens() | ||
| if access_token: |
Contributor
There was a problem hiding this comment.
Is this needed? Wouldn't old token storage be called to get token?
| upload_url = getattr(api_config, 'UPLOAD_URL', 'https://upload.box.com/api/2.0') | ||
| # Remove version suffix if present | ||
| if upload_url.endswith('/2.0'): | ||
| upload_url = upload_url[:-4] |
|
|
||
| return network_session | ||
|
|
||
| def get_sdk_gen_client(self, *, auth_options=None, network_options=None): |
lukaszsocha2
requested changes
Jan 23, 2026
Contributor
lukaszsocha2
left a comment
lukaszsocha2
left a comment
There was a problem hiding this comment.
Please move the method implementation to separate file. client.py is already huge. And split implementation into smaller methods. Avoid inner funtions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.