Skip to content

fix: flashblock benchmark scheduling #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meyer9 merged 3 commits into from
Jan 23, 2026
Merged

fix: flashblock benchmark scheduling #157

meyer9 merged 3 commits into from
Jan 23, 2026

Conversation

@meyer9
Copy link
Collaborator

@meyer9 meyer9 commented Jan 22, 2026 •
edited
Loading

Description

  • Synchronize flashblock sending with full block sending so we're sending the flashblocks for block N immediately after NewPayload is acknowledged for block N-1 via startedBlockSignal
  • Include last setup block in payloads so that we can start sending flashblocks immediately after the last setup block is processed (still don't collect metrics for this block though)
  • Group flashblocks by block during collection instead of during replay since only the first flashblock includes the base block info
  • Sleep for block time during validation (previously were calling NewPayload as fast as possible)

Testing

Tested with rbuilder and base-node-reth

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 22, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

meyer9
meyer9 commented Jan 22, 2026
View reviewed changes
runner/network/consensus/validator_consensus.go

startedBlockSignal <- payloads[i].Number + 1

time.Sleep(time.Until(startTime.Add(f.options.BlockTime)))
Copy link
Collaborator Author

@meyer9 meyer9 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, validator benchmark wasn't sleeping (also caused an issue with Reth processing spikes)

@meyer9 meyer9 marked this pull request as ready for review January 22, 2026 19:21
@meyer9 meyer9 requested a review from mw2000 January 22, 2026 19:21
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 22, 2026

Review Error for mw2000 @ 2026-01-22 19:58:30 UTC
User failed mfa authentication, see go/mfa-help

@meyer9 meyer9 enabled auto-merge (squash) January 22, 2026 20:00
mw2000
mw2000 previously approved these changes Jan 22, 2026
View reviewed changes
@cb-heimdall cb-heimdall dismissed mw2000’s stale review January 22, 2026 23:17

Approved review 3694865793 from mw2000 is now dismissed due to new commit. Re-request for approval.

@meyer9 meyer9 requested a review from mw2000 January 23, 2026 00:09
@meyer9 meyer9 merged commit 9743396 into main Jan 23, 2026
15 checks passed
@meyer9 meyer9 deleted the meyer9/fix-flashblock-bench branch January 23, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mw2000 mw2000 mw2000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meyer9 @cb-heimdall @mw2000