-
Notifications
You must be signed in to change notification settings - Fork 174
feat: add support for use_for_organization_discovery organizations discovery-domains
#1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kushalshit27
wants to merge
9
commits into
master
Choose a base branch
from
DXCDT-1349-self-service-org-domain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts type adjustments - src/tools/auth0/handlers/organizations.ts: add 'use_for_organization_discovery' property to domain schema - src/tools/auth0/handlers/organizations.ts: refactor domain update logic for better clarity - src/tools/auth0/handlers/organizations.ts: handle 'use_for_organization_discovery' in domain creation - src/tools/auth0/handlers/prompts.ts: update ScreenRenderer type to Management.GetAculResponseContent
- src/tools/auth0/handlers/organizations.ts: improve mapping of existing discovery domains to include remote IDs - src/tools/auth0/handlers/organizations.ts: filter out undefined updated domains during mapping
- test/context/directory/organizations.test.js: include use_for_organization_discovery in JSON organizations - test/context/yaml/organizations.test.js: add use_for_organization_discovery to YAML organizations - test/tools/auth0/handlers/organizations.tests.js: update sampleDiscoveryDomain and assertions for use_for_organization_discovery
use_for_organization_discovery organizations discovery domainsuse_for_organization_discovery organizations discovery-domains
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 80.28% 80.29%
=======================================
Files 146 146
Lines 5823 5825 +2
Branches 1193 1193
=======================================
+ Hits 4675 4677 +2
Misses 655 655
Partials 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
use_for_organization_discoveryboolean field in organization discovery domain operationspre-login-organization-pickerto prompts handler for organization picker screen renderingExamples
YAML format
JSON format
{ "name": "acme", "display_name": "Acme Inc", "discovery_domains": [ { "domain": "login.acme.com", "status": "verified", "use_for_organization_discovery": true }, { "domain": "auth.acme.com", "status": "pending", "use_for_organization_discovery": false } ] }🔬 Testing
use_for_organization_discoveryfield📝 Checklist