-
Notifications
You must be signed in to change notification settings - Fork 49
Add passkey support for the AsgardeoV2 (Thunder) #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b284a56 to
6b861d8
Compare
brionmario
reviewed
Jan 23, 2026
brionmario
reviewed
Jan 23, 2026
packages/react/src/components/presentation/auth/SignIn/v2/SignIn.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Jan 23, 2026
packages/react/src/components/presentation/auth/SignIn/v2/SignIn.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Jan 23, 2026
packages/react/src/components/presentation/auth/SignIn/v2/SignIn.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Jan 23, 2026
packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx
Outdated
Show resolved
Hide resolved
brionmario
previously approved these changes
Jan 23, 2026
brionmario
reviewed
Jan 23, 2026
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
brionmario
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds support for passkey-based authentication and registration to the sign-in and sign-up flows. It introduces new state management and effect hooks to trigger browser passkey popups and handle their responses, and updates the internationalization (i18n) files with passkey-related strings in multiple languages.
Passkey Authentication & Registration Integration:
SignIn.tsxandBaseSignUp.tsxto detect passkey challenges or creation options from the backend, trigger the browser's passkey UI, and submit the results to complete the authentication or registration flow. [1] [2] [3] [4] [5] [6] [7] [8]Internationalization (i18n) Updates:
I18nTranslationsinterface and updated translation files (en-US,fr-FR,hi-IN,ja-JP,pt-BR,pt-PT,si-LK,ta-IN,te-IN) to include new passkey-related UI strings for button labels, headings, and descriptions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Utilities:
handlePasskeyAuthenticationandhandlePasskeyRegistrationto handle the browser interactions for passkey flows. [1] [2]These changes enable seamless passkey-based authentication and registration across supported languages, improving both security and user experience.
Related Issues
Related PRs
Checklist
Security checks