Skip to content

Conversation

@DonOmalVindula
Copy link
Contributor

Purpose

This pull request focuses on code quality improvements and modernization across the express, i18n, and node packages. The main changes include updating copyright notices, improving code style and consistency, refactoring legacy code for better readability and maintainability, and enhancing TypeScript usage for type safety.

Code Modernization and Refactoring

  • Refactored private member variables in AsgardeoNodeClient and AsgardeoNodeCore classes to use more descriptive names (e.g., _authCoreauthCore, _authauth) and updated all method references accordingly for clarity and consistency (packages/node/src/__legacy__/client.ts, packages/node/src/__legacy__/core/authentication.ts). [1] [2]
  • Improved TypeScript type safety by introducing explicit types for constants, such as UUID_VERSION: number, and defining an interface for LOGGER_CONFIG (packages/node/src/__legacy__/constants/logger-config.ts, packages/node/src/__legacy__/constants/uuid-config.ts). [1] [2]

Copyright and License Updates

  • Updated copyright and license headers in multiple files to reflect the correct year (2025) and organization name (WSO2 LLC) for consistency and legal compliance (packages/express/src/index.ts, packages/node/src/__legacy__/constants/index.ts, packages/node/src/__legacy__/constants/logger-config.ts, packages/node/src/__legacy__/constants/uuid-config.ts, packages/node/src/__legacy__/core/authentication.ts). [1] [2] [3] [4] [5]

Code Style and Linting

  • Standardized import and export statements to use single quotes instead of double quotes for improved consistency (packages/express/src/index.ts, packages/node/src/__legacy__/constants/index.ts). [1] [2]
  • Added new directories to .eslintignore and disabled specific ESLint rules in config and test files to reduce unnecessary linting errors and improve developer experience (packages/express/.eslintignore, packages/i18n/vitest.config.ts, packages/express/vitest.config.ts, packages/i18n/src/translations/hi-IN.ts). [1] [2] [3] [4]

Test and Utility Improvements

  • Minor improvements to test files, such as fixing import order and using object destructuring for cleaner code in getDefaultI18nBundles.test.ts (packages/i18n/src/utils/__tests__/getDefaultI18nBundles.test.ts). [1] [2]

These changes collectively improve code maintainability, readability, and compliance with modern TypeScript and JavaScript standards.

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

brionmario
brionmario previously approved these changes Jan 22, 2026
@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants