fix: Fix Selenium 4.40.0+ compatibility

[valfirst]

Change list

• Address breaking changes from Selenium client: BiDi class constructor requires additional input parameter: SeleniumHQ/selenium@4cd4b09#diff-f0ed6d655b8c0ff47563631639d01d8f7a5f8e83a40db48456a2e9137e8ab0e6R33

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Note: new release is needed.

[asolntsev]

Ooops :)
It had to be backward-compatible change, leaving the previous constructor with the default timeout value...

[mykola-mokhnach]

does this limit the minimum supported selenium version to 4.40?

[asolntsev]

Yes.
Well, we could restore constructor new BiDi(biDiConnection) in Selenium 4.41.0.
Then we do a switch in Appium:

if <new constructor exists>
  return new BiDi(biDiConnection, timeout)
else
  return new BiDi(biDiConnection)

[valfirst]

I think it makes sense just to bump the minimum supported selenium version, otherwise we'll get a lot of complains and confusion. (It's not the first breaking change from Selenium)

PS: I've fixed README

[mykola-mokhnach]

Can we use reflection to make it backward compatible?

[valfirst]

yes, do you want me to re-work the PR?

[valfirst]

but still the release will be needed

[mykola-mokhnach]

Yes. Well, we could restore constructor new BiDi(biDiConnection) in Selenium 4.41.0. Then we do a switch in Appium:

if
return new BiDi(biDiConnection, timeout)
else
return new BiDi(biDiConnection)

this probably won't work. We'd need to load the class dynamically via Class.forName and also use an interface to access its methods, which will be a pain

I agree to @valfirst , it's not the first time we deal with such issues, yolo

[asolntsev]

It's not the first breaking change from Selenium

I don't know about other cases, but this specific was done occasionally. Sorry for that. :(

Don't you want to run Appium build against the night Selenium build (4.41.0-SNAPSHOT)?
In Selenide, we do the following:

1. Every PR and main branch is built against latest stable Selenium (4.40.0)
2. Additionally, every night we run a build from main branch against latest Selenium nightly build (4.41.0-SNAPSHOT)

It helps to detect backward incompatible changes on an early stage.