fix(backend): use dynamic DSLContext lookup to fix stale DB connections in tests #4179
+135
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongjinyoon
changed the title
seongjinyoon
changed the title
Contributor
|
@seongjinyoon Thanks for the PR. Please make the subject more informative. |
seongjinyoon
changed the title
Contributor
Author
|
@Xiao-zhen-Liu Please review this PR. Thank you! |
Xiao-zhen-Liu
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
LGTM. @seongjinyoon Could you add some doc in SqlServer to warn against caching the DSLContext, if there is no way to enforce dynamic lookup?
Xiao-zhen-Liu
requested changes
Jan 28, 2026
Contributor
Xiao-zhen-Liu
left a comment
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
I think there are some other places in the codebase that have this usage pattern, e.g., AuthResource. Please do a global check of all usages of createDSLContext() so we do not miss them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Fixed a test isolation issue where tests that use
MockTexeraDBpass when run individually but fail when run together (e.g.,sbt test).The root cause is that resource classes cache the database connection on first access. When a test class shuts down its
EmbeddedPostgresand the next test class starts a new one on a different port, the cached connection still points to the dead port, causing "Connection refused" errors.The fix ensures the connection is looked up fresh form
SqlServereach time instead of being cached, so it always reflects the current database.Files changed across 4 modules:
amber,file-service,computing-unit-managing-service,common/auth.Any related issues, documentation, discussions?
Closes #4178
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
Revised with Claude Code.