drivers/rpmsg: unify cpuname handling and fix pm wakelock initialization #18108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CV-Bowen
requested review from
anchao,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Drivers
jerpelea
approved these changes
Jan 22, 2026
xiaoxiang781216
approved these changes
Jan 22, 2026
Contributor
Author
|
Clone nuttx-testing failed, force push to retrigger CI Installing collected packages: pytz, pyserial, pyelftools, ptyprocess, urllib3, typing-extensions, tomli, pyyaml, pygments, psutil, pluggy, pillow, pexpect, packaging, iniconfig, idna, click, charset_normalizer, certifi, requests, exceptiongroup, pytest, pytest-timeout, pytest-repeat, pytest-ordering, pytest-dependency, ntfc
Running setup.py install for pytest-dependency: started
Running setup.py install for pytest-dependency: finished with status 'done'
Successfully installed certifi-2026.1.4 charset_normalizer-3.4.4 click-8.3.1 exceptiongroup-1.3.1 idna-3.11 iniconfig-2.3.0 ntfc-0.0.1 packaging-26.0 pexpect-4.9.0 pillow-12.1.0 pluggy-1.6.0 psutil-7.2.1 ptyprocess-0.7.0 pyelftools-0.32 pygments-2.19.2 pyserial-3.5 pytest-9.0.2 pytest-dependency-0.6.0 pytest-ordering-0.6 pytest-repeat-0.9.4 pytest-timeout-2.4.0 pytz-2025.2 pyyaml-6.0.3 requests-2.32.5 tomli-2.4.0 typing-extensions-4.15.0 urllib3-2.6.3
Cloning into 'nuttx-testing'...
remote: Internal Server Error
fatal: unable to access 'https://github.com/szafonimateusz-mi/nuttx-testing/': The requested URL returned error: 500 |
Fix the issue that pm feature not picked before rename the rpmsg_virtio to rpmsg_virtio_lite Signed-off-by: buxiasen <buxiasen@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
Unify all the cpuname/local_cpuname to struct rpmsg_s, so we can remove the ops->get_cpuname and ops->get_local_cpuname in struct rpmsg_ops_s. Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
CV-Bowen
force-pushed
the
rpmsg-cpuname
branch
from
9dd4ad2 to
91e5268
Compare
xiaoxiang781216
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two improvements to the RPMSG subsystem:
Unify cpuname/local_cpuname to struct rpmsg_s: Move the cpuname and local_cpuname fields from individual driver structures (rpmsg_port, rpmsg_virtio, rpmsg_virtio_lite, rpmsg_router_edge) to the common struct rpmsg_s. This eliminates the need for ops->get_cpuname and ops->get_local_cpuname callbacks in struct rpmsg_ops_s, simplifying the code and reducing duplication across different RPMSG backends.
Fix pm wakelock initialization in rpmsg_virtio_lite: Add missing pm wakelock name initialization that was not picked up during the rename from rpmsg_virtio to rpmsg_virtio_lite. This ensures proper power management functionality when CONFIG_RPMSG_VIRTIO_LITE_PM is enabled.
Impact
Code simplification: Removes ~120 lines of duplicated code across multiple RPMSG drivers
API cleanup: Removes two function pointers from struct rpmsg_ops_s
Bug fix: Restores pm wakelock functionality in rpmsg_virtio_lite driver
No breaking changes: Internal refactoring only, public API unchanged
Testing
Build test with qemu-armv8a:v8a_server and qemu-armv8a:v8a_proxy configurations:
RPMSG communication verified between server and proxy cores: