Skip to content

Conversation

@zhaoxingyu12
Copy link
Contributor

@zhaoxingyu12 zhaoxingyu12 commented Jan 23, 2026

Note: Please adhere to Contributing Guidelines.

Summary

Modify the Kconfig name of the mtdconfig module 2

Impact

mtdconfig module config

Testing

test it by CICT together with apache/nuttx#18120

Because the MTD_CONFIG configuration item in
drivers/mtd/Kconfig has changed

Signed-off-by: zhaoxingyu1 <zhaoxingyu1@xiaomi.com>
Because  MTD_CONFIG configuration item in drivers/mtd/Kconfig
has changed.

Signed-off-by: zhaoxingyu1 <zhaoxingyu1@xiaomi.com>
@zhaoxingyu12
Copy link
Contributor Author

Configuration/Tool: esp32c3-legacy-devkit/nvcfgdata
2026-01-23 03:26:54

Cleaning...
Configuring...
Building NuttX...
[1/1] Normalize esp32c3-legacy-devkit/nvcfgdata
49d48
< CONFIG_TESTING_MTD_CONFIG_FAIL_SAFE=y
Saving the new configuration file
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: boards/risc-v/esp32c3-legacy/esp32c3-legacy-devkit/configs/nvcfgdata/defconfig

no changes added to commit (use "git add" and/or "git commit -a")

report this error, because it needs CICT together with apache/nuttx#18120
it changes CONFIG_MTD_CONFIG_FAIL_SAFE to CONFIG_MTD_NVS
@xiaoxiang781216

@acassis
Copy link
Contributor

acassis commented Jan 23, 2026

@zhaoxingyu12 please include some testing results. Did you test CFGDATA too? Maybe we need to add CFGDATA to "SIM" or "QEMU" to make the test easy to do. Currently only two boards are using it

@acassis
Copy link
Contributor

acassis commented Jan 23, 2026

@zhaoxingyu12 I'm not sure that changing MTD_CONFIG to MTD_CONFIG_NONE is a good name change. I noticed your idea was to rename MTD_CONFIG_FAIL_SAFE to MTD_CONFIG_NVS, but it will be strange see CFGDATA depending on MTD_CONFIG_NONE.

Could you please add more details in the git commit message about this change? It seems very strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants