perf: Optimize scalar fast path for iszero #19919
Open
+90
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Jan 21, 2026
| assert!(booleans.value(1)); | ||
| assert!(!booleans.value(2)); | ||
| assert!(booleans.value(3)); | ||
| let array = Arc::new(Float32Array::from(vec![1.0, 0.0, 3.0, -0.0])); |
Contributor
There was a problem hiding this comment.
Could we move the tests to SLTs
Contributor
Author
There was a problem hiding this comment.
Do you want all of the unit test removed from here or only the new ones I added? All of these are already covered in slt.
Contributor
There was a problem hiding this comment.
It would be good if we can do it for all the tests there
Contributor
Author
There was a problem hiding this comment.
| Test | Coverage Status |
|---|---|
| test_iszero_f64 - array [1.0, 0.0, 3.0, -0.0] | Covered by scalar.slt:828 (column test with small_floats) |
| test_iszero_f32 - array [1.0, 0.0, 3.0, -0.0] | Covered by scalar.slt:828 (column test with small_floats) |
| test_iszero_scalar_f64_zero - 0.0 | iszero(0.0) in scalar.slt:816 and math.slt:116 |
| test_iszero_scalar_f64_neg_zero - -0.0 | iszero(-0.0) in scalar.slt:816 and math.slt:116 |
| test_iszero_scalar_f64_non_zero - 1.5 | iszero(10.0) returns false in scalar.slt:816, iszero(1.0) in math.slt:116 |
| test_iszero_scalar_null - null | iszero(NULL) in scalar.slt:822 and math.slt:116 |
Jefffrey
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
iszerofunction currently converts scalar inputs to arrays before processing, even for single scalar values. This adds unnecessary overhead from array allocation and conversion. Adding a scalar fast path avoids this overhead and improves performanceWhat changes are included in this PR?
Float16,Float32, andFloat64scalar inputsAre these changes tested?
Yes
Are there any user-facing changes?
No