fix: [iceberg] Fall back on dynamicpruning expressions for CometIcebergNativeScan #3335
+76
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Jan 29, 2026
| case _ | ||
| if scanExec.scan.getClass.getName == | ||
| "org.apache.iceberg.spark.source.SparkBatchQueryScan" => | ||
| if (scanExec.runtimeFilters.exists(isDynamicPruningFilter)) { |
Member
There was a problem hiding this comment.
do we need this check more widely for all v2 scans?
Contributor
Author
There was a problem hiding this comment.
I'm not sure about the blast radius on that, it's possible/likely.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
============================================
+ Coverage 56.12% 59.96% +3.83%
- Complexity 976 1474 +498
============================================
Files 119 175 +56
Lines 11743 16165 +4422
Branches 2251 2681 +430
============================================
+ Hits 6591 9693 +3102
- Misses 4012 5124 +1112
- Partials 1140 1348 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We're seeing issues on main with Iceberg tests due to CometIcebergNativeScan convert() failing to serialize a
dynamicpruningexpression, which leaves the CometBatchScan operator. When doExecuteColumnar() is called on that, we get the underlying Iceberg reader producing a type that Comet is not prepared for at the native columnar to row operator.I think this is a new bug exposed by #3299.
What changes are included in this PR?
dynamicpruningexpression.How are these changes tested?
New test, existing Iceberg tests should pass again.